TST: make pytables tests go thru a temporary dir and file #5422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TST/BUG: incorrect way of testing for r+ modes
|
I just fixed the merge conflict on the related PR. Once it passes I'll merge it and then you can do this one. Sound good? |
|
except don't put in any of the hdf stuff (or I can merge this first) |
| if filename is None: | ||
| filename = tempfile.mkstemp()[1] | ||
| # make sure that we are using a temp dir as well | ||
| suffix = filename if filename is not None and not len(os.path.dirname(filename)) else '' |
There was a problem hiding this comment.
Better to just do: if len(os.path.dirname(filename)): raise ValueError("Can't pass a directory path to ensure_clean") and then just do filename = filename or '' before that.
|
ok let me move this pr to your branch u can incorporate and merge all together |
|
closing in favor of #5419 |
jtratner
pushed a commit
to jtratner/pandas
that referenced
this pull request
Nov 3, 2013
jtratner
added a commit
to jtratner/pandas
that referenced
this pull request
Nov 3, 2013
Includes @jreback's commits from pandas-dev#5422 and hdf_temp: * TST: make pytables tests go thru a temporary dir and file * TST/BUG: incorrect way of testing for r+ modes
jreback
pushed a commit
to jreback/pandas
that referenced
this pull request
Nov 3, 2013
Includes @jreback's commits from pandas-dev#5422 and hdf_temp: * TST: make pytables tests go thru a temporary dir and file * TST/BUG: incorrect way of testing for r+ modes TST: fix temporary files by using mktemp (rather than mkstemp) which opens them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TST/BUG: incorrect way of testing for r+ modes
related #5419