Skip to content

STYLE: Add ruff check for multiple with statements #53466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

STYLE: Add ruff check for multiple with statements #53466

wants to merge 1 commit into from

Conversation

snorfyang
Copy link
Contributor

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label May 31, 2023
phofl
phofl reviewed Jun 1, 2023
View reviewed changes
pandas/tests/apply/test_invalid_arg.py
with tm.assert_produces_warning(warn, match=warn_msg, check_stacklevel=False):
string_series.transform(func)
with pytest.raises(
ValueError,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo this read terrible and would prefer doing this with 2 context managers

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach will be requested when the pull request is marked ready for review rhshadrach is a code owner

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STYLE: Add ruff check to avoid multiple with statements
3 participants
@snorfyang @mroeschke @phofl