TST: Adds test coverage for pd.read_json index type #53242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 15, 2023
mroeschke
reviewed
May 15, 2023
pandas/tests/io/json/test_pandas.py
Outdated
| df = DataFrame() | ||
| dfjson = read_json("{}", orient=orient, convert_axes=True) | ||
|
|
||
| assert df.index.dtype == dfjson.index.dtype |
There was a problem hiding this comment.
Could you compare the entire index?
dfjson = read_json("{}", orient=orient, convert_axes=True)
result = df.json.index
expected = df.index
tm.assert_index_equal(result, expected)Same for the .columns
There was a problem hiding this comment.
Will update with your suggestions shortly!
mroeschke
added
Testing
|
Updated with your suggestions @mroeschke |
mroeschke
reviewed
May 17, 2023
Co-authored-by: Matthew Roeschke <[email protected]>
|
Updated with your latest suggestion @mroeschke. Let me know if there is anything else. |
mroeschke
approved these changes
May 18, 2023
|
Thanks @mcgeestocks |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
* TST: Added test coverage for pd.read_json index type * Update pandas/tests/io/json/test_pandas.py Co-authored-by: Matthew Roeschke <[email protected]> * add coverage for entire index and columns. * Update pandas/tests/io/json/test_pandas.py Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Matthew Roeschke <[email protected]>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* TST: Added test coverage for pd.read_json index type * Update pandas/tests/io/json/test_pandas.py Co-authored-by: Matthew Roeschke <[email protected]> * add coverage for entire index and columns. * Update pandas/tests/io/json/test_pandas.py Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Description:
@mroeschke mentioned that the merged fix for issue #28558 could use a test. This PR adds the missing test for index type equality between the
DataFrameandread_jsonfunctions.