BUG: changing period array formats to specified date formats in to_csv
#51700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Mar 4, 2023
| data = [res.iget_values(i) for i in range(len(res.items))] | ||
| data = [ | ||
| self._change_to_str_date_format(res.iget_values(i)) | ||
| for i in range(len(res.items)) |
There was a problem hiding this comment.
This is the wrong place for this. We have formatters per dtype, it would have to be added there
There was a problem hiding this comment.
Gotcha. Thanks for pointing it out. Very helpful.
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_csvdate_formatis not taken into account forPeriodArrays #51621date_formatinto_csv.NDArrayBackedExtensionBlockinstead ofDatetimeLikeBlockso thatdf._mgr.to_native_typesdoes not change 'PeriodArray' to desired string format. This fix is added in afterdf._mgr.to_native_typesto changePeriodto specifieddate_format.