Skip to content

Enable Pylint warning consider-using-ternary #51051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 30, 2023
Merged

Enable Pylint warning consider-using-ternary #51051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ee6b72
Enable the Pylint check "consider-using-ternary"
Jan 13, 2023
34a0124
Reformat file
Jan 17, 2023
ade5b34
Merge branch 'main' into consider-using-ternary
Jan 26, 2023
a49d591
Merge branch 'main' into consider-using-ternary
Jan 28, 2023
a4e80ff
Fix error in ternary statement
Jan 30, 2023
e05abb4
Merge branch 'main' into consider-using-ternary
MarcoGorelli Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pandas/core/algorithms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,8 +1197,10 @@ def is_valid_dtype_n_method(dtype: DtypeObj) -> bool:
nsmallest/nlargest methods
"""
return (
is_numeric_dtype(dtype) and not is_complex_dtype(dtype)
) or needs_i8_conversion(dtype)
not is_complex_dtype(dtype)
if is_numeric_dtype(dtype)
else needs_i8_conversion(dtype)
)


class SelectNSeries(SelectN):
Expand Down
4 changes: 2 additions & 2 deletions pandas/io/stata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,7 +1221,7 @@ def _read_new_header(self) -> None:
raise ValueError(_version_error.format(version=self.format_version))
self._set_encoding()
self.path_or_buf.read(21) # </release><byteorder>
self.byteorder = self.path_or_buf.read(3) == b"MSF" and ">" or "<"
self.byteorder = ">" if self.path_or_buf.read(3) == b"MSF" else "<"
self.path_or_buf.read(15) # </byteorder><K>
nvar_type = "H" if self.format_version <= 118 else "I"
nvar_size = 2 if self.format_version <= 118 else 4
Expand Down Expand Up @@ -1413,7 +1413,7 @@ def _read_old_header(self, first_char: bytes) -> None:
raise ValueError(_version_error.format(version=self.format_version))
self._set_encoding()
self.byteorder = (
struct.unpack("b", self.path_or_buf.read(1))[0] == 0x1 and ">" or "<"
">" if struct.unpack("b", self.path_or_buf.read(1))[0] == 0x1 else "<"
)
self.filetype = struct.unpack("b", self.path_or_buf.read(1))[0]
self.path_or_buf.read(1) # unused
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,6 @@ disable = [
"unnecessary-lambda-assignment",

# pylint type "R": refactor, for bad code smell
"consider-using-ternary",
"consider-using-with",
"cyclic-import",
"duplicate-code",
Expand Down