BUG: fixed a bug in multi-level indexing with a Timestamp partial indexer (GH4294) #5088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -408,7 +408,7 @@ cdef class Float64Engine(IndexEngine): | |||
| limit=limit) | |||
|
|
|||
|
|
|||
| cdef Py_ssize_t _bin_search(ndarray values, object val): | |||
| cdef Py_ssize_t _bin_search(ndarray values, object val) except -1: | |||
There was a problem hiding this comment.
I'm assuming that only positive ints and 0 are returned here, is that correct? or more specifically that -1 can't be returned as an index ... if you return -1 explicitly you'll get a runtimerror saying you didn't set the exception handler or soemthing like that .. i don't remember the specific error
There was a problem hiding this comment.
the error was not bubbling up..
There was a problem hiding this comment.
yep ... that's bc of not declaring except -1 ... i answered my own question
jreback
added a commit
that referenced
this pull request
Oct 2, 2013
BUG: fixed a bug in multi-level indexing with a Timestamp partial indexer (GH4294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4294