Skip to content

REF: share string parsing code #50736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2023
Merged

REF: share string parsing code #50736

merged 2 commits into from
Jan 16, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli self-requested a review January 13, 2023 18:48
@MarcoGorelli
Copy link
Member

look great! will do a final check after a call I have in a few mins, then will approve/merge

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Jan 16, 2023
@MarcoGorelli MarcoGorelli added Refactor Internal refactoring of code Datetime Datetime data dtype labels Jan 16, 2023
MarcoGorelli
MarcoGorelli approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @jbrockmendel !

@MarcoGorelli MarcoGorelli merged commit 13f5395 into pandas-dev:main Jan 16, 2023
@jbrockmendel jbrockmendel deleted the ref-parse-share branch January 16, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Refactor Internal refactoring of code
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @MarcoGorelli