TYP: return values in core/*.py #47587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Jul 3, 2022
| inplace: Literal[False] = ..., | ||
| axis=..., | ||
| level=..., | ||
| errors: IgnoreRaise | lib.NoDefault = ..., |
There was a problem hiding this comment.
errors is not used in NDFrame/Series/DataFrame.where (and also in mask, which just calls where). Does errors need to go through a depreciation cycle, or can it simply be removed?
There was a problem hiding this comment.
in either way, I will address it in a follow-up PR
There was a problem hiding this comment.
It would probably need a deprecation cycle to be safe
phofl
reviewed
Jul 3, 2022
mzeitlin11
reviewed
Jul 4, 2022
mroeschke
reviewed
Jul 6, 2022
mroeschke
reviewed
Jul 6, 2022
mroeschke
approved these changes
Jul 6, 2022
|
Thanks @twoertwein |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TYP: return values in core/*.py * fix test * to_html * to_html part 2 * DataFrame.query * more overloads * fix query? * increase stacklevel by one * fix rename_axis * and an overload for DataFrame.eval * address comments * fix typevar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is quite a bit larger since many functions needed overloads.