Skip to content

TYP: Expanding.__init__ #47308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2022
Merged

TYP: Expanding.__init__ #47308

merged 2 commits into from
Jun 12, 2022

Conversation

twoertwein
Copy link
Member

No description provided.

@mroeschke
Copy link
Member

LGTM. Could you rebase? The code checks were not working when you originally opened this PR.

@twoertwein
Copy link
Member Author

LGTM. Could you rebase? The code checks were not working when you originally opened this PR.

This time it ran :) Might be worth skipping the typing tests only if building pandas fails.

@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Jun 12, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jun 12, 2022
@mroeschke mroeschke merged commit d489393 into pandas-dev:main Jun 12, 2022
@mroeschke
Copy link
Member

Thanks @twoertwein

Might be worth skipping the typing tests only if building pandas fails.

I think this should be the case since we have if: ${{ steps.build.outcome == 'success' }} in the GHA job.

@twoertwein
Copy link
Member Author

I think the typing tests are also skipped when the doc-build/tests fail?

@mroeschke
Copy link
Member

Hmm that shouldn't be the case.

The docbuild is in a separate workflow, docbuild-and-upload.yml, from the typing checks, code-checks.yml which each build a separate version of pandas. So if the docbuild fails the typing checks in code-checks still run.

@twoertwein
Copy link
Member Author

Sorry, I meant the Docstring and typing validation workflow:

image

@mroeschke
Copy link
Member

Ah gotcha, yes correct. If any of the prior checks fail, then the whole workflow will stop. Feel free to add a continue-on-error: true in a subsequent PR for all the actual code checking steps

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@twoertwein twoertwein deleted the Expanding branch September 21, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants