TYP: Expanding.__init__

[twoertwein]

No description provided.

[mroeschke]

LGTM. Could you rebase? The code checks were not working when you originally opened this PR.

[twoertwein]

LGTM. Could you rebase? The code checks were not working when you originally opened this PR.

This time it ran :) Might be worth skipping the typing tests only if building pandas fails.

[mroeschke]

Thanks @twoertwein

Might be worth skipping the typing tests only if building pandas fails.

I think this should be the case since we have if: ${{ steps.build.outcome == 'success' }} in the GHA job.

[twoertwein]

I think the typing tests are also skipped when the doc-build/tests fail?

[mroeschke]

Hmm that shouldn't be the case.

The docbuild is in a separate workflow, docbuild-and-upload.yml, from the typing checks, code-checks.yml which each build a separate version of pandas. So if the docbuild fails the typing checks in code-checks still run.

[twoertwein]

Sorry, I meant the Docstring and typing validation workflow:

[mroeschke]

Ah gotcha, yes correct. If any of the prior checks fail, then the whole workflow will stop. Feel free to add a continue-on-error: true in a subsequent PR for all the actual code checking steps