TYP: Replace namedtuple with dataclass #40531 #43107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions pre-commit EDITlooks like not all tests get run from the automated commit, so closing and reopening. but then that stopped the azure checks, so I added an empty commit - now all the CI checks seem to be running fine |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
…3107) * TYP: Replace namedtuple with dataclass pandas-dev#40531 * Fixes from pre-commit [automated commit] * noop Co-authored-by: MarcoGorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces namedtuple with dataclass in pandas/core/groupby/base.py and closes #40531.
The parameters
orderandfrozenis set equal to True to make sure that that behaviour of OutputKey does not change.