TST: use fixtures for some sql database connections #42976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangchenli
added
Testing
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
Thanks for the PR but appears that it has gone stale. Feel free to reopen if you have time to continue working on it! |
mroeschke
reviewed
Nov 30, 2021
| @@ -367,6 +375,270 @@ def test_frame3(): | |||
| return DataFrame(data, columns=columns) | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
There was a problem hiding this comment.
Does it makes sense for the the engine and connection fixtures to be scope="module" so they are not repeatedly created and destroyed?
There was a problem hiding this comment.
The fixtures also do cleanups after each test. So it's better to have a new engine/conn for each test. Also, they don't seem to add much overhead.
mroeschke
reviewed
Nov 30, 2021
|
@fangchenli happyt o take this if you can fixup |
mroeschke
approved these changes
Dec 21, 2021
|
thanks @fangchenli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #40686
This PR:
We probably should put all the fixtures in a separate conftest.py file. But since there are unmerged PRs related to this test file, I kept everything in one place for now to avoid conflict.