Skip to content

fix typo - change conn to con #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2013
Merged

fix typo - change conn to con #4127

merged 1 commit into from
Jul 5, 2013

Conversation

tshauck
Copy link
Contributor

@tshauck tshauck commented Jul 4, 2013

Noticed a typo in the documentation of write_frame.

Method def has con while documentation had conn.

def write_frame(frame, name, con, flavor='sqlite', if_exists='fail', **kwargs):

@jtratner
Copy link
Contributor

jtratner commented Jul 4, 2013

Convention generally is to call connection conn and not con, so maybe the fix should go in the other direction. e.g. in the Python docs for sqlite3.

@tshauck
Copy link
Contributor Author

tshauck commented Jul 4, 2013

I agree and just made the change, however now that I pushed the change I went back and looked the rest of the file and it seems to use con for everything.

So I think I'll push back only the documentation update, however I'd be happy to revise the entire file...

@jtratner
Copy link
Contributor

jtratner commented Jul 4, 2013

good call

On Thu, Jul 4, 2013 at 1:07 PM, Trent Hauck [email protected]:

I agree and just made the change, however now that I pushed the change I
went back and looked the rest of the file and it seems to use con for
everything.

So I think I'll push back only the documentation update, however I'd be
happy to revise the entire file, but until somebody with more clout weighs
in I'll leave it as the simple doc fix.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4127#issuecomment-20486555
.

@hayd
Copy link
Contributor

hayd commented Jul 5, 2013

@tshauck Thanks for finding/fixing this!

Do you mind deleting the last two commits or rebase squashing the last three? so either

git reset --hard HEAD~2

or

git rebase -i HEAD~3

@tshauck
Copy link
Contributor Author

tshauck commented Jul 5, 2013

@hayd Happy to do it... I just pushed the change.

hayd added a commit that referenced this pull request Jul 5, 2013
fix typo - change conn to con
@hayd hayd merged commit 6a0b9ec into pandas-dev:master Jul 5, 2013
@hayd
Copy link
Contributor

hayd commented Jul 5, 2013

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants