DOC: elaborate on copies vs in place operations in comparison docs #38994
Conversation
|
|
||
| sorted_df = df.sort_values("col1") | ||
|
|
||
| * Use the ``inplace=True`` keyword argument, where available |
There was a problem hiding this comment.
frown on this
in place is never recommended
There was a problem hiding this comment.
A few options:
- Say "in order of preference"
- Mention
inplaceas "you will come across this, but don't use it" - Remove mention entirely
Strong feelings?
There was a problem hiding this comment.
i ok with mentioning it, but put it in a note and point to this link: https://pandas.pydata.org/pandas-docs/dev/user_guide/indexing.html#indexing-view-versus-copy
There was a problem hiding this comment.
Done, though the "Returning a view versus a copy" section doesn't actually mention inplace. I'd submit a pull request to add an explanation, but frankly, that's one area of pandas that's still pretty fuzzy to me.
There was a problem hiding this comment.
What I mean is "I'm not sure I understand it fully myself, so would love an explanation from someone else" 😊
There was a problem hiding this comment.
oh i c. check this blog by @TomAugspurger https://tomaugspurger.github.io/method-chaining.html
generaly inplace doesn't do a whole lot, is not idiomatic, and cause copy/view issues.
|
also pls merge master |
afeld
force-pushed
the
comparison-copy-vs-in-place
branch
from
698a3d1 to
0ff288c
Compare
|
thanks ! |
closes #xxxxwhatsnew entry