DEPR: Add FutureWarning when matching NaN with NaN in merge/join #37405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
not averse to doing this @phofl if you can add a test that shows the warning. |
jreback
added
Deprecate
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
@phofl if you can update or close. |
|
Closing this for now, have to evaluate here. To be consistent this would influence a lot of index methods too, if nan should no longer match nan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffcc @WillAyd
I started with raising a FutureWarning when merging nan on nan. This works, if
left_indexandright_indexare not both True.If both are True, we are dispatching to the Index methods. Should we deprecate this for indexes too? Additionally, should we remove this for
intersectionof index in the future too? Will continue after receiving feedback :)