Skip to content

raise on fillna passed a list or tuple #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2013
Merged

raise on fillna passed a list or tuple #3585

merged 1 commit into from
May 13, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 13, 2013

fixes #3435.

@jreback
Copy link
Contributor

jreback commented May 13, 2013

pls add a release notes mention (and in general if its worth of the whatsnew a mention of that too)

@cpcloud
Copy link
Member Author

cpcloud commented May 13, 2013

@jreback Okay. Rule of thumb for when to add a rls notes mention?

@jreback
Copy link
Contributor

jreback commented May 13, 2013

pretty much anything non-trivial should get in release notes (or trivial but its a API change or bug)

if its a separate issue (e.g. documented), I always put in release notes with an issue link. Docs don't bother (unless again it has an actual issue attached, e.g. #3566) whatsnew if it is an non-trivial API change, or you want to 'announce' it, e.g. your regex stuff will certainly need a whatsnew (and docs), as its useful and new behavior. I just do a quick ipython (usually based off the tests), or you have doc strings, whatever works.

so this needs a mention (as its an issue). If you had just discovered this (and not an op), then maybe doesn't make much difference as a future user would then read the doc string and not be suprised (or get the exception).

@cpcloud
Copy link
Member Author

cpcloud commented May 13, 2013

cool. great explntn.

@jreback
Copy link
Contributor

jreback commented May 13, 2013

this looks ready for merge, yes?

@jreback
Copy link
Contributor

jreback commented May 13, 2013

@cpcloud can you rebase....this is the annoyance with release notes. the fact that I merged something in a different order causes these things to not be auto mergable.....thxs

@cpcloud
Copy link
Member Author

cpcloud commented May 13, 2013

@jreback rebased

@cpcloud
Copy link
Member Author

cpcloud commented May 13, 2013

better commit message

jreback added a commit that referenced this pull request May 13, 2013
@jreback jreback merged commit 8897021 into pandas-dev:master May 13, 2013
@cpcloud cpcloud deleted the fillna-raise-on-value-is-list-3435 branch May 22, 2013 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fillna() does not work when value parameter is a list
2 participants