Skip to content

REF: inline get_day_of_month #34772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2020
Merged

REF: inline get_day_of_month #34772

merged 1 commit into from
Jun 14, 2020

Conversation

jbrockmendel
Copy link
Member

Makes the logic in all cases of shift_months identical, same for shift_quarters. Next pass does de-duplication.

@jreback jreback added the Frequency DateOffsets label Jun 14, 2020
@jreback jreback added this to the 1.1 milestone Jun 14, 2020
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

sure

@jbrockmendel
Copy link
Member Author

green

@jreback jreback merged commit c482b57 into pandas-dev:master Jun 14, 2020
@jbrockmendel jbrockmendel deleted the ref-liboffsets-inline-get_day_of_month branch June 14, 2020 19:52
@jbrockmendel
Copy link
Member Author

excellent. ideally #34760 would go in before i do the de-duplication branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Frequency DateOffsets
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback