Skip to content

CLN/TYPE: EWM #34770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2020
Merged

CLN/TYPE: EWM #34770

merged 5 commits into from
Jun 14, 2020

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jun 14, 2020 •
edited
Loading

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  1. Move min_periods validation to constructor
  2. Stronger cython type defintions
  3. Typing EWM methods

@mroeschke mroeschke added Clean Typing type annotations, mypy/pyright type checking Window rolling, ewma, expanding labels Jun 14, 2020
@mroeschke mroeschke added this to the 1.1 milestone Jun 14, 2020
jreback
jreback approved these changes Jun 14, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

@mroeschke mroeschke merged commit 28be10b into pandas-dev:master Jun 14, 2020
@mroeschke mroeschke deleted the clean_and_type_ewm branch June 14, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Typing type annotations, mypy/pyright type checking Window rolling, ewma, expanding
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback