Skip to content

TST: GroupBy(..., as_index=True).agg() drops index #33098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 15, 2020
Merged

TST: GroupBy(..., as_index=True).agg() drops index #33098

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
35a4dd6
BUG: Add test for #28641 to ensure that error does not occur again
phofl Mar 28, 2020
3f7bd80
BUG: Run black pandas
phofl Mar 28, 2020
7bb76ce
Implement requested review changes
phofl Mar 31, 2020
145f171
Implement requested review changes
phofl Mar 31, 2020
85f7f6f
Rename test
phofl Apr 1, 2020
8628b83
Change xfail Message in test
phofl Apr 3, 2020
ba9fd7b
Merge branch 'master' of https://github.com/pandas-dev/pandas into 28…
phofl Apr 12, 2020
a757791
Merge tests at end of file
phofl Apr 12, 2020
01b98ab
Merge remote-tracking branch 'upstream/master' into BUG_28641_add_tests
simonjayhawkins May 22, 2020
5f8dfb9
Merge branch 'master' of https://github.com/pandas-dev/pandas into 28641
phofl Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pandas/tests/groupby/aggregate/test_aggregate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,15 @@ def test_aggregate_mixed_types():
tm.assert_frame_equal(result, expected)


def test_aggregate_categorical_lost_index():
# GH: 28641 groupby drops index, when grouping over categorical column with min/max
ds = pd.Series(["b"], dtype="category").cat.as_ordered()
df = pd.DataFrame({"A": [1997], "B": ds})
result = df.groupby("A").agg({"B": "min"})
expected = pd.DataFrame({"B": ["b"]}, index=pd.Index([1997], name="A"))
tm.assert_frame_equal(result, expected)


@pytest.mark.xfail(reason="Not implemented.")
def test_aggregate_udf_na_extension_type():
# https://github.com/pandas-dev/pandas/pull/31359
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/groupby/test_categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,3 +1380,13 @@ def test_groupby_agg_non_numeric():

result = df.groupby([1, 2, 1]).nunique()
tm.assert_frame_equal(result, expected)


def test_groupy_first_returns_categorical():
# GH 28641: groupby drops index, when grouping over categorical column with first
df = pd.DataFrame(
{"A": [1997], "B": pd.Series(["b"], dtype="category").cat.as_ordered()}
)
result = df.groupby("A")["B"].first()
expected = pd.Series(["b"], index=pd.Index([1997], name="A"), name="B")
tm.assert_series_equal(result, expected)