-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: pd.concat fails when handling MultiIndex if repeated index exists #31113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: pd.concat fails when handling MultiIndex if repeated index exists #31113
Conversation
Can you check benchmarks for this? I would think that replacing the internal factorize with itertools.chain could drastically slow things down |
thanks! @WillAyd changed btw, just a question, somehow, yesterday when i was trying to check benchmark, it takes ages and I felt my laptop almost burned, is this normal for local benchmark checking? I will check the benchmark tomorrow |
Running the entire benchmark suite will take a while. You probably want to limit it to what you think is the affected code, so something like |
Hello @charlesdong1991! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-04-13 09:00:15 UTC |
@charlesdong1991 still active? Can you fix merge conflicts and try to get CI green? |
yeah, still active, but i will be off for vacation for several days, and this needs some work so will update in a week. @WillAyd 👍 |
@charlesdong1991 what's the status here? |
emm, let me close for now, haven't past tests locally. will reopen once finding a way. |
xref #20565
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff