Skip to content

BUG: pd.concat fails when handling MultiIndex if repeated index exists #31113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

charlesdong1991
Copy link
Member

@charlesdong1991 charlesdong1991 commented Jan 17, 2020

xref #20565

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@WillAyd
Copy link
Member

WillAyd commented Jan 17, 2020

Can you check benchmarks for this? I would think that replacing the internal factorize with itertools.chain could drastically slow things down

@charlesdong1991
Copy link
Member Author

thanks! @WillAyd changed

btw, just a question, somehow, yesterday when i was trying to check benchmark, it takes ages and I felt my laptop almost burned, is this normal for local benchmark checking?

I will check the benchmark tomorrow

@WillAyd
Copy link
Member

WillAyd commented Jan 17, 2020

Running the entire benchmark suite will take a while. You probably want to limit it to what you think is the affected code, so something like asv continuous upstream/master HEAD -b join_merge.Concat for this PR

@simonjayhawkins simonjayhawkins added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jan 18, 2020
@pep8speaks
Copy link

pep8speaks commented Jan 19, 2020

Hello @charlesdong1991! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-13 09:00:15 UTC

@WillAyd
Copy link
Member

WillAyd commented Feb 12, 2020

@charlesdong1991 still active? Can you fix merge conflicts and try to get CI green?

@charlesdong1991
Copy link
Member Author

charlesdong1991 commented Feb 12, 2020

yeah, still active, but i will be off for vacation for several days, and this needs some work so will update in a week. @WillAyd 👍

@simonjayhawkins
Copy link
Member

@charlesdong1991 what's the status here?

@charlesdong1991
Copy link
Member Author

emm, let me close for now, haven't past tests locally. will reopen once finding a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants