Split test multi #20669
Split test multi #20669
Conversation
|
Hello @xchoudhury! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on April 13, 2018 at 05:02 Hours UTC |
|
|
||
| class TestConstructor(Base): | ||
| _holder = MultiIndex | ||
| _compat_props = ['shape', 'ndim', 'size', 'itemsize'] |
There was a problem hiding this comment.
so things that are not used in a particular module need not be repeated here (e.g. in the constructor) and/or properties in the class.
We want to actually remove the need for the class entirely. You could do that here as well (or in a next pass PR).
This is a little trickier because need to turn things (like self.index) into fixtures. so ok with doing this later.
| def create_index(self): | ||
| return self.index | ||
|
|
||
| def test_set_name_methods(self): |
There was a problem hiding this comment.
rather these go with the names methods
| self.index.labels = new_labels | ||
|
|
||
| def test_set_levels(self): | ||
| # side note - you probably wouldn't want to use levels and labels |
There was a problem hiding this comment.
similar this should go with get_levels
There was a problem hiding this comment.
see below get/set names/levels/labels can all be in 1 file
| check_dtype=True) | ||
|
|
||
| def test_set_labels(self): | ||
| # side note - you probably wouldn't want to use levels and labels |
There was a problem hiding this comment.
get/set lables/levels can be in 1 file
| result = sorted_idx.slice_locs('bar', 'baz') | ||
| assert result == (2, 4) | ||
|
|
||
| def test_slice_locs_not_contained(self): |
There was a problem hiding this comment.
moving slice, get_loc, get_indexer into a test_indexing
|
|
||
| import numpy as np | ||
|
|
||
| from pandas import (Index, MultiIndex) |
|
|
||
| def create_index(self): | ||
| return self.index | ||
|
|
There was a problem hiding this comment.
move all of the constructors (from_product, from_array, from_tuples) into a test_constructor
| self.setup_indices() | ||
|
|
||
| def create_index(self): | ||
| return self.index |
There was a problem hiding this comment.
move this with test_format
| minor_labels = np.array([0, 1, 0, 1, 0, 1]) | ||
| self.index_names = ['first', 'second'] | ||
| self.indices = dict(index=MultiIndex(levels=[major_axis, minor_axis], | ||
| labels=[major_labels, minor_labels |
There was a problem hiding this comment.
you can put unique, isin, duplicates in a single file
jreback
added
Testing
|
make sure you rebase on origin/master |
|
@xchoudhury I see you've done a lot of good work on splitting out the multi index tests. Would you like any help polishing this off? I'd be happy to assist. |
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>git diff upstream/master -u -- "*.py" | flake8 --diffpython doc/make.py --single <your-function-or-method>Please include the output of the validation script below between the "```" ticks:
If the validation script still gives errors, but you think there is a good reason
to deviate in this case (and there are certainly such cases), please state this
explicitly.
Checklist for other PRs (remove this part if you are doing a PR for the pandas documentation sprint):
git diff upstream/master -u -- "*.py" | flake8 --diff