Skip to content

move implementation of Timedelta to tslibs.timedeltas #18085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 8, 2017
Merged

move implementation of Timedelta to tslibs.timedeltas #18085

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
06af5a6
move implementation of Timedelta to tslibs.timedeltas
jbrockmendel Nov 3, 2017
60c9a9d
whitespace fixup
jbrockmendel Nov 3, 2017
b592640
fixes per reviewer comments
jbrockmendel Nov 3, 2017
0b236f8
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 3, 2017
73b5d21
update imports of _delta_to_nanoseconds; de-privatize
jbrockmendel Nov 3, 2017
98e339a
fixup uncomment
jbrockmendel Nov 3, 2017
cc1886b
update import
jbrockmendel Nov 3, 2017
0176832
whitespace fixup
jbrockmendel Nov 4, 2017
a394d7b
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 5, 2017
5130c21
add depends
jbrockmendel Nov 5, 2017
967d608
typo fixup
jbrockmendel Nov 5, 2017
a6c65bc
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 5, 2017
f30844d
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 8, 2017
9a46526
edits per reviewer requests
jbrockmendel Nov 8, 2017
e9fba12
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 8, 2017
f5e8fe0
update imports
jbrockmendel Nov 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/_libs/tslib.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from numpy cimport ndarray, int64_t

from tslibs.conversion cimport convert_to_tsobject
from tslibs.timedeltas cimport convert_to_timedelta64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these shouldn’t be here
if something wants to import them they should directly cimport from conversion or timedelta and not tslib


cpdef convert_to_timedelta64(object, object)
cdef bint _check_all_nulls(obj)

cdef _to_i8(object val)
Loading