TST: check internal Categorical #13249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Testing
5 tasks
| @@ -685,8 +687,8 @@ def _check_types(l, r, obj='Index'): | |||
| assert_class_equal(left, right, exact=exact, obj=obj) | |||
| assert_attr_equal('dtype', l, r, obj=obj) | |||
| # allow string-like to have different inferred_types | |||
| if l.inferred_type in ('string', 'unicode'): | |||
| assertIn(r.inferred_type, ('string', 'unicode')) | |||
| if l.inferred_type in ('string', 'unicode', 'mixed'): | |||
There was a problem hiding this comment.
hmm, you sure about this? 'mixed' could be lots of things, even an integer & string will trigger.
There was a problem hiding this comment.
Ah, this is no longer required. Removed (originally tried to handle .categories contains NaN).
| @@ -253,9 +253,11 @@ def test_unstack_fill(self): | |||
| # By default missing values will be NaN | |||
| result = data.unstack() | |||
| expected = DataFrame({'a': pd.Categorical(list('axa'), | |||
| categories=list('abc')), | |||
There was a problem hiding this comment.
so we explicity force these to ordered? (or is it starting with an ordered cat)? this seems odd.
sinhrks
force-pushed
the
test_categorical
branch
2 times, most recently
from
2dae9e8 to
9d5a577
Compare
|
thanks @sinhrks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff