-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG/API: QuarterBegin n=0 #11406 #11777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
The general semantics of anchored offsets for ``n=0`` is to not move the date | ||
when it is an anchor point (e.g., a quarter start date), and otherwise roll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the issue number reference here
cc @cancan101 look ok to you? |
Looks fine to me, though I don't recall ever commenting on offsets. On Dec 7, 2015, at 1:24 PM, Jeff Reback <[email protected]mailto:[email protected]> wrote: cc @cancan101https://github.com/cancan101 look ok to you? Reply to this email directly or view it on GitHubhttps://github.com//pull/11777#issuecomment-162493690. |
From #8435 does this now return something sensible?
|
cc @MichaelWS |
Looks sensible to me |
merged via 56fd4e3 thanks! |
closes #11406 - makes
QuarterBegin
forn=0
match Month/Year.xref #11427 - once this is merged the failures there should pass - there is also a little more documentation about general offset semantics in that PR.