Skip to content

Use empty_frame fixture #33161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillAyd opened this issue Mar 31, 2020 · 4 comments
Closed

Use empty_frame fixture #33161

WillAyd opened this issue Mar 31, 2020 · 4 comments
Labels
Enhancement Testing pandas testing functions or related to the test suite

Comments

@WillAyd
Copy link
Member

WillAyd commented Mar 31, 2020

#33148 introduced an empty_frame fixture in the top level conftest. At the same time, we have a lot of ... = DataFrame() assignments in our tests. We should standardize to use the fixture where appropriate

@WillAyd WillAyd added good first issue Testing pandas testing functions or related to the test suite labels Mar 31, 2020
@WillAyd WillAyd added this to the Contributions Welcome milestone Mar 31, 2020
@jason3804
Copy link

Hi, I'm new to open source. Can I take this issue?

@WillAyd
Copy link
Member Author

WillAyd commented Mar 31, 2020 via email

@anish29292
Copy link

can I take a look at this issue?

anish29292 pushed a commit to anish29292/pandas that referenced this issue Mar 31, 2020
Replaced Empty data frames with fixture empty_frame()
@simonjayhawkins simonjayhawkins added Needs Discussion Requires discussion from core team before further action and removed good first issue labels May 8, 2020
@mroeschke mroeschke added Enhancement and removed Needs Discussion Requires discussion from core team before further action labels May 22, 2020
@jbrockmendel
Copy link
Member

Fixture has been removed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Testing pandas testing functions or related to the test suite
Projects
None yet
6 participants