Skip to content

BLD: numpy 1.16.1 failing builds #25511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Mar 1, 2019 · 4 comments · Fixed by #25517
Closed

BLD: numpy 1.16.1 failing builds #25511

jreback opened this issue Mar 1, 2019 · 4 comments · Fixed by #25517
Labels
Build Library building on various platforms
Milestone
0.24.2

Comments

@jreback
Copy link
Contributor

jreback commented Mar 1, 2019

looks like our builds are failing as we are now picking up numpy 1.16.1; I belive 1.16.2 fixes this, so once this is fully pushed should be ok.

These failures manifest with pytables. https://travis-ci.org/pandas-dev/pandas/jobs/500453356

cc @pandas-dev/pandas-core

let's hold off merging for now / we could simply pin numpy=1.15.* as well (again for now), if someone wants to do this.
@jreback jreback added the Build Library building on various platforms label Mar 1, 2019
@jreback jreback added this to the 0.25.0 milestone Mar 1, 2019
@gfyoung
Copy link
Member

gfyoung commented Mar 1, 2019

People were already noticing this issue back in #24839.

@jreback
Copy link
Contributor Author

jreback commented Mar 1, 2019

I understand, but our master builds just picked this up. I suspect because now all packages are actually available for numpy 1.16 (which wasn't the case before; this takes some time, esp in default)

@gfyoung
Copy link
Member

gfyoung commented Mar 1, 2019 •
edited
Loading

@jreback : For sure. I just wanted to link this issue to that one for reference.

@gfyoung
Copy link
Member

gfyoung commented Mar 2, 2019

1.16.2 is available via the conda-forge channel

jreback added a commit to jreback/pandas that referenced this issue Mar 2, 2019
@jreback
TST: xfail non-writeable pytables tests with numpy 1.16x
6e3b2b1 
closes pandas-dev#25511
@jreback jreback mentioned this issue Mar 2, 2019
Merged
@jreback jreback modified the milestones: 0.25.0, 0.24.2 Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.24.2
Development

Successfully merging a pull request may close this issue.

TST: xfail non-writeable pytables tests with numpy 1.16x jreback/pandas
2 participants
@jreback @gfyoung