-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
TST/CI: PyArrow Test Failures #17581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just updated packages to 0.7.0 today, so let's investigate and resolve |
Looking at the green build before, there has been a |
Yeah, so it looks like a feature that was unsupported before is now supported, so this is a good kind of failure |
I recommend that we pin pandas builds at a particular pyarrow version so that we can update pandas and fix bugs in a PR rather than letting builds randomly start failing |
most of the builds are pinned but to catch things like this on purpose i did not pin several |
Oh nice. Can we set one of the builds in the build matrix to run against the nightlies ( |
@jreback : Maybe it would be better to add |
@wesm : Along similar lines to what you said, perhaps we could just run an allowed-failure build of |
no its much better to flag this in a highly visible manner - allowed failures are only marked this way to make the build turn 'finish' faster - they r still not allowed the pr to fix will take about 5 minutes |
further his is very common and has happened many times with matplotlib and dateutil among others |
we already have a build that hits numpy / scipy dailies. easy enough to add pyarrow |
True, it's just that I think people freak out more when they see a failure on the non-allowed failures. |
I am fine either way, but pyarrow at this point is no longer alpha and while APIs may change this package should be working all the time in production from PyPI and conda-forge. So whether or not failures are allowed in Travis CI they should be fixed immediately |
@wesm : Absolutely. I'm just proposing this change for the sake of not scarring people who are less familiar with our code when they contribute to |
Totally, I'm with you on that. I think allowed failures on the unpinned builds is reasonable |
Uh oh!
There was an error while loading. Please reload this page.
Weird
pyarrow
failures going on with 37e23d:https://travis-ci.org/pandas-dev/pandas/jobs/276857797
https://travis-ci.org/pandas-dev/pandas/jobs/276857799
Looks unrelated to commit, so something probably went wrong with
pyarrow
cc @jreback @jorisvandenbossche @wesm
The text was updated successfully, but these errors were encountered: