Skip to content

TST/CI: PyArrow Test Failures #17581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gfyoung opened this issue Sep 18, 2017 · 15 comments · Fixed by #17588
Closed

TST/CI: PyArrow Test Failures #17581

gfyoung opened this issue Sep 18, 2017 · 15 comments · Fixed by #17588
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Milestone

Comments

@gfyoung
Copy link
Member

gfyoung commented Sep 18, 2017

Weird pyarrow failures going on with 37e23d:

https://travis-ci.org/pandas-dev/pandas/jobs/276857797
https://travis-ci.org/pandas-dev/pandas/jobs/276857799

Looks unrelated to commit, so something probably went wrong with pyarrow

cc @jreback @jorisvandenbossche @wesm

@gfyoung gfyoung added CI Continuous Integration Testing pandas testing functions or related to the test suite labels Sep 18, 2017
@gfyoung gfyoung added this to the 0.21.0 milestone Sep 18, 2017
@wesm
Copy link
Member

wesm commented Sep 18, 2017

Just updated packages to 0.7.0 today, so let's investigate and resolve

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Sep 18, 2017

Looking at the green build before, there has been a pyarrow update from 0.6.0 to 0.7.0

@wesm
Copy link
Member

wesm commented Sep 18, 2017

Yeah, so it looks like a feature that was unsupported before is now supported, so this is a good kind of failure

@wesm
Copy link
Member

wesm commented Sep 18, 2017

I recommend that we pin pandas builds at a particular pyarrow version so that we can update pandas and fix bugs in a PR rather than letting builds randomly start failing

@jreback
Copy link
Contributor

jreback commented Sep 18, 2017

most of the builds are pinned

but to catch things like this on purpose i did not pin several

@wesm
Copy link
Member

wesm commented Sep 18, 2017

Oh nice. Can we set one of the builds in the build matrix to run against the nightlies (conda install pyarrow -c twosigma) with allowed failures? That might be helpful to get early feedback in case there is a regression or some other failure

@gfyoung
Copy link
Member Author

gfyoung commented Sep 18, 2017

@jreback : Maybe it would be better to add pyarrow builds like these to allowed failures? No reason to block PR's just because of a 3rd-party library update that is unrelated to their changes.

@gfyoung
Copy link
Member Author

gfyoung commented Sep 18, 2017

@wesm : Along similar lines to what you said, perhaps we could just run an allowed-failure build of pandas against a nightly build as one of our allowed failures just so we can catch these compat issues in advance.

@jreback
Copy link
Contributor

jreback commented Sep 18, 2017

no its much better to flag this in a highly visible manner - allowed failures are only marked this way to make the build turn 'finish' faster - they r still not allowed

the pr to fix will take about 5 minutes
welcome for someone to do it otherwise i will tomorrow

@jreback
Copy link
Contributor

jreback commented Sep 18, 2017

further his is very common and has happened many times with matplotlib and dateutil among others

@jreback
Copy link
Contributor

jreback commented Sep 18, 2017

we already have a build that hits numpy / scipy dailies. easy enough to add pyarrow

@gfyoung
Copy link
Member Author

gfyoung commented Sep 18, 2017

they r still not allowed

True, it's just that I think people freak out more when they see a failure on the non-allowed failures.

@wesm
Copy link
Member

wesm commented Sep 18, 2017

I am fine either way, but pyarrow at this point is no longer alpha and while APIs may change this package should be working all the time in production from PyPI and conda-forge. So whether or not failures are allowed in Travis CI they should be fixed immediately

@gfyoung
Copy link
Member Author

gfyoung commented Sep 18, 2017

So whether or not failures are allowed in Travis CI they should be fixed immediately

@wesm : Absolutely. I'm just proposing this change for the sake of not scarring people who are less familiar with our code when they contribute to pandas.

@wesm
Copy link
Member

wesm commented Sep 18, 2017

Totally, I'm with you on that. I think allowed failures on the unpinned builds is reasonable

jreback added a commit to jreback/pandas that referenced this issue Sep 19, 2017
jreback added a commit to jreback/pandas that referenced this issue Sep 19, 2017
jreback added a commit to jreback/pandas that referenced this issue Sep 19, 2017
jreback added a commit that referenced this issue Sep 19, 2017
alanbato pushed a commit to alanbato/pandas that referenced this issue Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this issue Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants