Skip to content

BUG: DataFrame.insert value is too strict #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phofl opened this issue Feb 7, 2023 · 1 comment · Fixed by #543
Closed

BUG: DataFrame.insert value is too strict #529

phofl opened this issue Feb 7, 2023 · 1 comment · Fixed by #543
Labels
good first issue

Comments

@phofl
Copy link
Member

phofl commented Feb 7, 2023

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

  1. Provide a minimal runnable pandas example that is not properly checked by the stubs.
  2. Indicate which type checker you are using (mypy or pyright).
  3. Show the error message received from that type checker while checking your example.
df = DataFrame({"a": [1, 2]})
df.insert(loc=0, column="b", value=None)

error: Value of type variable "ListLike" of "insert" of "DataFrame" cannot be "None"  [type-var]

Please complete the following information:

  • OS: [e.g. Windows, Linux, MacOS] MacOS
  • OS Version [e.g. 22] Venturar 13.1
  • python version 3.10
  • version of type checker mypy 0.991
  • version of installed pandas-stubs latest

Additional context
Add any other context about the problem here.

According to the main repo, any Scalar is allowed
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Feb 7, 2023

Need to change

pandas-stubs/pandas-stubs/core/frame.pyi

Line 546 in 495e91f

value: int | ListLike,

to be value: Scalar | ListLikeU | None with appropriate tests.

@Dr-Irv Dr-Irv mentioned this issue Feb 17, 2023
Merged
2 tasks
Dr-Irv pushed a commit that referenced this issue Feb 19, 2023
@ramvikrams
gh-529 Fixing Dataframe.insert (#543)
00ab656 
* Update test_frame.py

* Update frame.pyi

* Update test_frame.py

* Changed assert_type

* Update test_frame.py

* Update test_frame.py
twoertwein pushed a commit to twoertwein/pandas-stubs that referenced this issue Apr 1, 2023
@ramvikrams @twoertwein
pandas-devgh-529 Fixing Dataframe.insert (pandas-dev#543)
d28ed1c 
* Update test_frame.py

* Update frame.pyi

* Update test_frame.py

* Changed assert_type

* Update test_frame.py

* Update test_frame.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-529 Fixing Dataframe.insert
2 participants
@Dr-Irv @phofl