Skip to content

[12/n] [sled-agent] don't start install dataset zones on mupdate override error #8237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: sunshowers/spr/main.12n-sled-agent-dont-start-install-dataset-zones-on-mupdate-override-error
Choose a base branch
from

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented May 29, 2025

For mupdate overrides, in order to be safe, we must know that the data stored in the JSON is consistent with the images stored on disk. We currently apply this logic to both install dataset and artifact hashes, since we need to consult mupdate override info for the

TODO: testing on a racklette, putting this up to get feedback for now

Questions:

  • Should we apply this logic to more critical zones like the switch zone? They're always going to be part of the ramdisk maybe?
  • How does this interact with config-reconciler work? That would permanently be blocked it seems to me.
  • We ask for the boot zpool to be passed in but also cache it as part of constructing the info... how do we reconcile the relative presence or absence of this info?

Depends on:

Created using spr 1.3.6-beta.1
@sunshowers sunshowers requested a review from jgallagher May 29, 2025 07:53
@sunshowers sunshowers marked this pull request as draft May 29, 2025 18:55
@sunshowers
Copy link
Contributor Author

sunshowers commented May 29, 2025

We need to figure out what to do if the mupdate override is not in place (i.e. if it was removed by sled-agent). Presumably the install dataset will still be around in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant