-
Notifications
You must be signed in to change notification settings - Fork 11
Separate T6 and (optional) K.2 NIC setup for compliance images. #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a much better direction, thanks for this.
Just one minor comment from me, I don't know enough about how the compliance/mfg bits get used to approve but those parts look reasonable.
be85579
to
75396a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think anything that isn't specifically related to compliance should have any mention of compliance scrubbed out. We ship the NIC configuration stuff in essentially every image, so I think making it an oxide/
prefix on the FMRI, and removing any mention of compliance, would make it easier to understand the scope.
This adds a new service
site/compliance/net-setup
which ensures we have an IPv6 link-local address for the NICs corresponding to each instance of the service. Each instance is named after the corresponding NIC driver (e.g.,e1000g
,igb
,cxgbe
).