Skip to content

[FSSDK-9491] chore Prepare for 2.0.0-beta release #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 22, 2023
Merged

[FSSDK-9491] chore Prepare for 2.0.0-beta release #67

merged 9 commits into from
Sep 22, 2023

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Sep 21, 2023 •
edited
Loading

Summary

  • Prepare for release 2.0.0-beta

Issues

  • FSSDK-9491

@muzahidul-opti muzahidul-opti marked this pull request as ready for review September 21, 2023 16:36
jaeopt
jaeopt requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added a feature to specify client sdk name and version.
Can we use that to push "fluter-sdk" and its own version?

@muzahidul-opti
Copy link
Contributor Author

We added a feature to specify client sdk name and version. Can we use that to push "fluter-sdk" and its own version?

Yah, that's a good catch. But this one is not released yet for Swift. We can add it later.

@mikechu-optimizely mikechu-optimizely removed their request for review September 22, 2023 13:49
jaeopt
jaeopt approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 2f8ddfd into master Sep 22, 2023
@muzahidul-opti muzahidul-opti deleted the 2.0.0-beta branch September 22, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt