Skip to content

[FSSDK-8840]: Adds native Android implementation for ODP #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented May 15, 2023

Summary

  • Adds native Android implementation for ODP
  • Updates Android sdk version to 4.0.0-beta

Test plan

  • All previous unit tests should pass.

Issues

@mnoman09 mnoman09 closed this May 16, 2023
@mnoman09 mnoman09 reopened this May 16, 2023
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some minor suggestions.

Comment on lines 511 to 516
try {
optimizelyClient.sendODPEvent(type, action, identifiers, data);
result.success(createResponse());
} catch (Exception ex) {
result.success(createResponse(ex.getMessage()));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean-up this try catch block.

@yasirfolio3 yasirfolio3 reopened this May 18, 2023
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yasirfolio3 yasirfolio3 merged commit 69959d4 into master May 19, 2023
@yasirfolio3 yasirfolio3 deleted the mnoman/odpAndroidSupport branch May 19, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants