-
Notifications
You must be signed in to change notification settings - Fork 1
[FSSDK-8840]: Adds native Android implementation for ODP #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just some minor suggestions.
android/src/main/java/com/optimizely/optimizely_flutter_sdk/OptimizelyFlutterClient.java
Show resolved
Hide resolved
try { | ||
optimizelyClient.sendODPEvent(type, action, identifiers, data); | ||
result.success(createResponse()); | ||
} catch (Exception ex) { | ||
result.success(createResponse(ex.getMessage())); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please clean-up this try catch block.
android/src/main/java/com/optimizely/optimizely_flutter_sdk/helper_classes/ArgumentsParser.java
Show resolved
Hide resolved
android/src/main/java/com/optimizely/optimizely_flutter_sdk/helper_classes/Constants.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/optimizely/optimizely_flutter_sdk/helper_classes/Constants.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
4.0.0-beta
Test plan
Issues