new module resty.limit.count #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangjn
reviewed
Jul 14, 2017
| -- TODO: we could avoid the tricky FFI cdata when lua_shared_dict supports | ||
| -- hash-typed values as in redis. | ||
| ffi.cdef[[ | ||
| struct lua_resty_limit_ghe_req_rec { |
There was a problem hiding this comment.
Need to be: struct lua_resty_limit_count_rec {
| return nil, "shdict abused by other users" | ||
| end | ||
| local rec = ffi_cast(const_rec_ptr_type, v) | ||
| local ttl = tonumber(rec.reset) - now |
There was a problem hiding this comment.
For tonumber(rec.reset) show 2 times, could you change to current way:
`
local rec = ffi_cast(const_rec_ptr_type, v)
reset = tonumber(rec.reset)
local ttl = reset - now
-- print("ttl: ", ttl, "s")
if ttl > 0 then
remaining = tonumber(rec.remaining) - 1
else
reset = now + window
remaining = limit
end
`
tangjn
reviewed
Jul 14, 2017
| remaining = tonumber(rec.remaining) - 1 | ||
| else | ||
| reset = now + window | ||
| remaining = limit |
There was a problem hiding this comment.
It should be: remaining = limit -1
Because initial remaining will triger by user access, so current access will using 1 access. So that need to be: limit -1
|
@tangjn Thank you for your review. Also need some test cases in the existing test suite to cover this new module. |
moonming
reviewed
Sep 1, 2017
| local setmetatable = setmetatable | ||
| local ffi_cast = ffi.cast | ||
| local ffi_str = ffi.string | ||
| local abs = math.abs |
| local rec = ffi_cast(const_rec_ptr_type, v) | ||
| local remaining = tonumber(rec.remaining) + 1 | ||
|
|
||
| rec_cdata.remaining = min(remaining, limit) |
moonming
reviewed
Sep 1, 2017
| local limit_count = require "resty.limit.count" | ||
|
|
||
| -- rate: 5000 requests per 3600s | ||
| local lim, err = limit_count.new("api_limit_count_store", 5000, 3600) |
There was a problem hiding this comment.
the name of shared dict should be my_limit_count_store.
|
#21 supersedes this and has already merged into master. Closing this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16