8357135: java.lang.OutOfMemoryError: Error creating or attaching to libjvmci after JDK-8356447

[dougxc]

As of JDK-8356447, libgraal initialization happens during VM startup. If during this initialization, the libgraal heap cannot be created due to lack of virtual address space, the VM will exit with:

Error occurred during initialization of VM
java.lang.OutOfMemoryError: Error creating or attaching to libjvmci (err: -1000000801, description: Reserving address space for the new isolate failed.)

This causes problems for tests that limit the virtual address space with ulimit -v such as gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java and vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java.
Since these tests were passing on libgraal prior to JDK-8356447, they obviously do not require JIT compilation. The simplest fix is to then use -Xint to disable the JIT.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357135: java.lang.OutOfMemoryError: Error creating or attaching to libjvmci after JDK-8356447 (Bug - P4)

Reviewers

• Yudi Zheng (@mur47x111 - Committer) Review applies to 32986d1a
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25307/head:pull/25307
$ git checkout pull/25307

Update a local copy of the PR:
$ git checkout pull/25307
$ git pull https://git.openjdk.org/jdk.git pull/25307/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25307

View PR using the GUI difftool:
$ git pr show -t 25307

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25307.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357135: java.lang.OutOfMemoryError: Error creating or attaching to libjvmci after JDK-8356447

Reviewed-by: never, yzheng

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

• 72e440d: 8357303: (fs) UnixSecureDirectoryStream.implDelete has unused haveFlags parameter
• 12efc1f: 8357165: test java/lang/invoke/ClassValueTest.java fails intermittently
• 428d33e: 8357462: Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as manual
• ... and 66 more: https://git.openjdk.org/jdk/compare/fbc12be73217315d66792b6ad3faacab133bb9d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (3201a5d6)
• 03: Full - Incremental (b0d45b1b)
• 02: Full - Incremental (1a79617e)
• 01: Full - Incremental (32986d1a)
• 00: Full (7eb259b9)

[mur47x111]

LGTM

[tkrodriguez]

Silently disabling the top level JIT seems like a bad default behaviour for customers.

[dougxc]

Silently disabling the top level JIT seems like a bad default behaviour for customers.

This does not disable the JIT, just suppresses a specific type of error (i.e., reserving virtual address space for the SVM heap) when trying to initialize libgraal at startup. Importantly, the error of badly specified libgraal options still causes a VM exit.

What alternative solution would you prefer? One of the other 2 proposals in the PR description? Or something else?

[tkrodriguez]

After this executes we have a running JVM without a working libgraal right? It might be rare in a user environment but it's very confusing behaviour for an end user. Might this not occur in a virtualized environment?

I agree it would be very hard to make libgraal robust in the face of such a limited virtual address space so I think disabling the tests for libgraal would be easiest. Or both of those tests could probably just run with -Xint to avoid this completely.

[dougxc]

Or both of those tests could probably just run with -Xint to avoid this completely.

I've reverted to this solution - thanks for the suggestion.

[dougxc]

Tested locally with a build that includes libgraal.

[dougxc]

/label add hotspot-gc

[openjdk]

@dougxc
The hotspot-gc label was successfully added.

[tkrodriguez]

This seems reasonable to me.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit 1258af4.
Since your change was applied there have been 70 commits pushed to the master branch:

• 16d4551: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk
• 72e440d: 8357303: (fs) UnixSecureDirectoryStream.implDelete has unused haveFlags parameter
• 12efc1f: 8357165: test java/lang/invoke/ClassValueTest.java fails intermittently
• ... and 67 more: https://git.openjdk.org/jdk/compare/fbc12be73217315d66792b6ad3faacab133bb9d5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 1258af4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.