8357193: [VS 2022 17.14] Warning C5287 in debugInit.c: enum type mismatch during build

[mrserb]

This patch suppresses compiler warning C5287 triggered in debugInit.c when building with Visual Studio 2022 version 17.14 (released a few days ago).

I’m simply disabling the warning to unblock the broken build. This change is intended to be backported to update releases.

A proper fix (e.g., explicit type cast) may be introduced later if necessary.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357193: [VS 2022 17.14] Warning C5287 in debugInit.c: enum type mismatch during build (Bug - P3)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25293/head:pull/25293
$ git checkout pull/25293

Update a local copy of the PR:
$ git checkout pull/25293
$ git pull https://git.openjdk.org/jdk.git pull/25293/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25293

View PR using the GUI difftool:
$ git pr show -t 25293

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25293.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357193: [VS 2022 17.14] Warning C5287 in debugInit.c: enum type mismatch during build

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• ab985a7: 8341544: Restore fence() in Mutex
• 0db5511: 8354969: Add strdup function for ResourceArea
• f8fc7ee: 8357052: java/io/File/GetXSpace.java prints wrong values in exception
• ... and 29 more: https://git.openjdk.org/jdk/compare/6c42856b8d5039c14ba04a48c60d09039d5030fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mrserb The following labels will be automatically applied to this pull request:

• build
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0d205e9d)

[plummercj]

Other references to the jvmti version in the debug agent use the result of calling GetVersionNumber(), which provides a jint. These references are otherwise doing the same bit masking and not seeing this warning. Using the compile time JVMTI_VERSION is appropriate for the code in question (it wants the compile time version), and simply casting it to a jint should resolve the warning.

[mrserb]

Unfortunately it cannot be suppressed by the cast due to bug in VS2022

I can suppress it by extracting JVMTI_VERSION into local variable similar to how other code looks like:

jint version = JVMTI_VERSION;
jvmtiCompileTimeMajorVersion  = ( version & JVMTI_VERSION_MASK_MAJOR )
                                    >> JVMTI_VERSION_SHIFT_MAJOR;
jvmtiCompileTimeMinorVersion  = ( version & JVMTI_VERSION_MASK_MINOR )
                                    >> JVMTI_VERSION_SHIFT_MINOR;
jvmtiCompileTimeMicroVersion  = ( version & JVMTI_VERSION_MASK_MICRO )
                                    >> JVMTI_VERSION_SHIFT_MICRO;

but it might be better just suppress it in the make file?

[kimbarrett]

The various constants involved here are currently defined as enumerators of
(different) unscoped enums. Perhaps they shouldn't be enumerators at all.
https://github.com/openjdk/jdk/blame/9927ec0b91775db342b2bbc1937253325c367a19/doc/hotspot-style.md#L670-L674
Ordinarily I would say these ought to be typed constexprs, probably jint
since these seem to be actual Java values. But some of the code involved needs
to be both valid C and valid C++, which makes that noticeably harder.

I'm okay with the proposed warning suppression as a quick fix for a build
failure, but there should be a followup bug to fix it properly.

[sspitsyn]

I can suppress it by extracting JVMTI_VERSION into local variable similar to how other code looks like:

jint version = JVMTI_VERSION;
jvmtiCompileTimeMajorVersion = ( version & JVMTI_VERSION_MASK_MAJOR )
>> JVMTI_VERSION_SHIFT_MAJOR;
jvmtiCompileTimeMinorVersion = ( version & JVMTI_VERSION_MASK_MINOR )
>> JVMTI_VERSION_SHIFT_MINOR;
jvmtiCompileTimeMicroVersion = ( version & JVMTI_VERSION_MASK_MICRO )
>> JVMTI_VERSION_SHIFT_MICRO;

but it might be better just suppress it in the make file?

I like the suggestion to extract JVMTI_VERSION into a local variable. Fixing it in the make file is fine too.

[mrserb]

I guess everyone agreed to disable the warning in the makefile?

[mrserb]

/integrate

[openjdk]

Going to push as commit 5f38d1b.
Since your change was applied there have been 47 commits pushed to the master branch:

• 735c789: 8334717: Add JVMCI support for APX EGPRs
• a0cdf36: 8357224: Avoid redundant WeakHashMap.get in Toolkit.removeAWTEventListener
• 9119451: 8355756: G1HeapSizingPolicy::full_collection_resize_amount should consider allocation size
• ... and 44 more: https://git.openjdk.org/jdk/compare/6c42856b8d5039c14ba04a48c60d09039d5030fe...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 5f38d1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.