8357165: test java/lang/invoke/ClassValueTest.java fails intermittently

[liach]

The test was originally written with product builds in mind; it didn't consider the slowness of debug builds, thus causing tests to fail.

Also there was a bug in testWeakAgainstClassValue: the test need to flush the backing map in the class to have the weak value removed. It is fixed in this patch as well.

Testing: ClassValueTest repeated 10 times on windows-x64/linux-x64/macosx-aarch64/linux-aarch64 fastdebug.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8357165: test java/lang/invoke/ClassValueTest.java fails intermittently

Issue

• JDK-8357165: test java/lang/invoke/ClassValueTest.java fails intermittently (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25292/head:pull/25292
$ git checkout pull/25292

Update a local copy of the PR:
$ git checkout pull/25292
$ git pull https://git.openjdk.org/jdk.git pull/25292/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25292

View PR using the GUI difftool:
$ git pr show -t 25292

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25292.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357165: test java/lang/invoke/ClassValueTest.java fails intermittently

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (68a13bb3)
• 00: Full (792d683e)

[jaikiran]

Hello Chen, in general for tests like these we don't use any explicit timeout value for waiting on certain condition. It's based on our past experiences in the CI and various other test runtime environments where no timeout value is a "right" timeout and can cause intermittent timeouts like here.

In this test, I think we should just switch to using await() and join() i.e. no specific timeouts. If there is any bug (either in the test or the product code) and the test doesn't complete, then the jtreg's timeout infrastructure will fail the test and at the same time has the necessary features to collect all necessary details to help debug those unexpected timeout failures.

[liach]

I still wish to keep these explicit timeouts - they can be fiddled around for debugging when something stalls after a ClassValue change. In comparison, the argless variants are much harder to tweak and/or debug.

[jaikiran]

The update to increase the timeout to 1 minute * timeout factor, looks good to me.

I'm not too familiar with the bug that's requiring the testWeakAgainstClassValue() method to be updated, but if that helps with the test failures then it seems reasonable to fix it.

[liach]

The failing tier 1 tests on GitHub are gc ones. Thanks for the reviews! I think we are good to go.

[liach]

/integrate

[openjdk]

Going to push as commit 12efc1f.
Since your change was applied there have been 24 commits pushed to the master branch:

• 428d33e: 8357462: Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as manual
• 1e57648: 8350457: Implement JEP 519: Compact Object Headers
• 26053fe: 8357406: Remove usages of jdk.tracePinnedThreads system property from httpclient tests
• ... and 21 more: https://git.openjdk.org/jdk/compare/6546de1d3adb8c4755950ee6fb858ec9ee1c5294...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 12efc1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.