Skip to content

8356629: Incorrect use of {@linkplain} in java.sql #25286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented May 17, 2025

Please review this trivial patch to fix a javadoc bug.

TIA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356629: Incorrect use of {@linkplain} in java.sql (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25286/head:pull/25286
$ git checkout pull/25286

Update a local copy of the PR:
$ git checkout pull/25286
$ git pull https://git.openjdk.org/jdk.git pull/25286/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25286

View PR using the GUI difftool:
$ git pr show -t 25286

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25286.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2025

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2025

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356629: Incorrect use of {@linkplain} in java.sql

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 111 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 17, 2025

@nizarbenalla The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@nizarbenalla nizarbenalla marked this pull request as ready for review May 19, 2025 11:29
@openjdk openjdk bot added the rfr Pull request is ready for review label May 19, 2025
@mlbridge
Copy link

mlbridge bot commented May 19, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 23, 2025
@nizarbenalla
Copy link
Member Author

Thanks for the review

/integrate

@openjdk
Copy link

openjdk bot commented May 25, 2025

Going to push as commit b034710.
Since your change was applied there have been 124 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2025
@openjdk openjdk bot closed this May 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2025
@openjdk
Copy link

openjdk bot commented May 25, 2025

@nizarbenalla Pushed as commit b034710.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nizarbenalla nizarbenalla deleted the incorrect-link-tags-java.sql branch May 26, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants