Patch python SDK generator to read aiohttp response data

[aaguiarz]

Summary

• ensure handle_response_exception awaits aiohttp responses so that the response body is available during error handling
• test that the response data is read when raising an exception

Testing

• make test-client-python (fails: docker: command not found)

---

https://chatgpt.com/codex/tasks/task_e_684ffad4696883229e03bdb7a6ff13ea

Summary by CodeRabbit

• Bug Fixes

  • Ensured error responses include the full response body for improved error handling in the Python REST client.

• Tests

  • Added an asynchronous test to confirm proper reading and assignment of response data during error handling.

[coderabbitai]

Walkthrough

A conditional block was added to the Python REST client template to asynchronously read and attach the response body to the response object when handling exceptions involving aiohttp.ClientResponse. Corresponding asynchronous test coverage was introduced to verify this behavior, including mocking and assertion of the response data handling.

Changes

File(s)	Change Summary
config/clients/python/template/src/rest.py.mustache	Enhanced handle_response_exception to asynchronously read and attach response data for aiohttp responses.
config/clients/python/template/test/rest_test.py.mustache	Added async test to verify response data reading and error handling; imported aiohttp for mocking.

Poem

A hop, a skip, a Python byte,
Now errors show their data right!
With async reads and tests anew,
Our client’s smart, our tests are true.
The bunny cheers with every hop—
For catching bugs, we never stop! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 983325b and f0ab3ac.

📒 Files selected for processing (1)

• config/clients/python/template/src/rest.py.mustache (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• config/clients/python/template/src/rest.py.mustache

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: build-and-test-go-sdk
• GitHub Check: build-and-test-python-sdk
• GitHub Check: build-and-test-java-sdk
• GitHub Check: build-and-test-dotnet-sdk
• GitHub Check: build-and-test-js-sdk
• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (actions)
• GitHub Check: Analyze (go)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5dd0b8 and 983325b.

📒 Files selected for processing (2)

• config/clients/python/template/src/rest.py.mustache (1 hunks)
• config/clients/python/template/test/rest_test.py.mustache (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: build-and-test-java-sdk
• GitHub Check: build-and-test-python-sdk
• GitHub Check: build-and-test-go-sdk
• GitHub Check: build-and-test-js-sdk
• GitHub Check: build-and-test-dotnet-sdk
• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (go)
• GitHub Check: Analyze (actions)

🔇 Additional comments (2)

config/clients/python/template/test/rest_test.py.mustache (2)

6-6: Import addition looks good

The explicit aiohttp import is required for the spec=aiohttp.ClientResponse mocks below. 👍

---

177-200: Solid behavioural test – but update once the double-read guard is in place

The test correctly asserts that:

1. the response body is awaited exactly once, and
2. ValidationException is raised with response.data populated.

After applying the guard suggested in rest.py, this test will still pass because read() is awaited once (not twice). No changes needed here.

Please re-run the test suite after patching handle_response_exception to confirm nothing regresses.