pika: added instrumentation for pika.connection.Connection and pika.c… #3584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hannel.Channel, thus added instrumentation support to all SelectConnection adapters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for the pika base connection and channel classes. Thus making all the
SelectConnectionadapters to be automatically instrumented.Fixes #920
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Added relavent tests cases based on current tests for the
opentelemetry-instrumentation-pika.by running
tox -l | grep sio-pika | xargs -L1 tox -eDoes This PR Require a Core Repo Change?
No.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.