TraceID is the same for all spans

[ty-elastic]

Describe your environment

OS: python:3.12.6-slim-bookworm
Python version: python:3.12.6
SDK version: 0.50b0/1.29.0
API version: 0.50b0/1.29.0

What happened?

Create a simple zero-code Python app invoked with opentelemetry-instrument. Whether you use auto-instrumentation (here, a flask endpoint) or add manual instrumentation (@tracer.start_as_current_span), the Trace IDs created for subsequent traces are all the same when using version 0.50b0/1.29.0. Keeping everything else the same, using 0.49b2/1.28.2, Trace IDs are randomly generated.

Steps to Reproduce

See https://github.com/ty-elastic/otel-python-bug and observe Collector debug output varying the version of the python OTel libraries used.

Basically, create a simple python app and use zero-code instrumentation. Either use an auto-instrumented library (like flask) or manually create spans. Using 0.50b0/1.29.0, Trace ID doesn't change between traces; using 0.49b2/1.28.2 it does (as expected).

Expected Result

Trace ID is randomly generated.

Actual Result

Trace ID is the same for every trace.

Additional context

No response

Would you like to implement a fix?

No

[xrmx]

@ty-elastic could you please check if pip3 uninstall opentelemetry-instrumentation-click after the opentelemetry-bootstrap call helps?

[ty-elastic]

yes, indeed, that fixes it. I now see random Trace IDs for each trace generated.

[ty-elastic]

@xrmx , I'm casually looking at the source of that instrumentation. What is it that would cause Trace ID not to be regenerated? Presumably that instrumentation is somehow being invoked to create a new Trace when my app is run, with that singular Trace ID on the context as the active parent, and then everything else is inherently a child span? Is there something about thew way I'm invoking my app that is triggering the click instrumentation to get accidentally hooked?

[xrmx]

@xrmx , I'm casually looking at the source of that instrumentation. What is it that would cause Trace ID not to be regenerated? Presumably that instrumentation is somehow being invoked to create a new Trace when my app is run, with that singular Trace ID on the context as the active parent, and then everything else is inherently a child span? Is there something about thew way I'm invoking my app that is triggering the click instrumentation to get accidentally hooked?

flask run under the hood is a click command, and one that lives forever so all the requests spans would be children of the very same root span. We should stop instrumenting flask run by default as it creates more harm than good 😅

[emdneto]

Also related: #3171
flask spans are also marked as kind.Internal since there's already a current-span in context (the click command one)