Keep style.css in ES module #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `src/style.css` file is not kept in the distributed ES module. Keeping it would allow to import it directly and keep it up to date when using Plot from a package manager.
|
We can include this in the distribution, but you still won’t be able to import or require the style.css because it’s not part of the declared exports. I’m not really sure how to support this type of usage. |
|
I'm using webpack, and with a css-loader it is possible to "import" a CSS file in a bundle. I'm doing it in another project with the Observable runtime inspector CSS, so I think it should work with Plot too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
src/style.cssfile is not kept in the distributed ES module. If I understand correctly, keeping it would allow to import it directly and keep it up to date when using Plot from a package manager.