text stroke channels #469
Merged
text stroke channels #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
approved these changes
Aug 2, 2021
|
Thank you for adding a test! I’d like our examples to try to be representative of good visualizations and best practices (for some minimal definition of “good” and “best”); people will inevitably use them to learn and as starting points for exploration. I couldn’t think of a “good” use of the text stroke channel, so I removed it from the test, but maybe it’d be worth adding as a unit test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467.
(It’d be nice to consolidate this code somehow, but I don’t think that needs to block this PR.)