fix: avoid double application of a scale transform #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
changed the title
mbostock
approved these changes
May 27, 2023
There was a problem hiding this comment.
Nice! This is almost exactly the solution I imagined too.
I renamed channel.transformed to channel.transform and inverted the meaning: it now means whether to apply the scale’s transform and defaults to true; if false, then the scale’s transform is bypassed. I think this is clearer if an initializer wants to declare that a channel should bypass the scale’s transform, and is similar to what we do for channel.filter. I also added it to the Channel interface.
mbostock
force-pushed
the
fil/double-transform
branch
from
3beb45f to
9870085
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* avoid double application of a scale transform when using a derived mark (such as a tip) * transform instead of transformed --------- Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using a derived mark (such as a tip), a scale transform was applied twice