Skip to content

test warnings #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2023
Merged

test warnings #1643

merged 2 commits into from
May 27, 2023

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented May 26, 2023

This tests that the “extra element” warnings added to #1633 are triggering when expected, and removes them from the console for a tidy test output. Snapshot tests that start with “warn” are now required to generate a warning, while other tests are required to not generate a warning.

@mbostock mbostock requested a review from Fil May 26, 2023 23:40
@mbostock mbostock merged commit 2911d55 into main May 27, 2023
@mbostock mbostock deleted the mbostock/test-warnings branch May 27, 2023 17:15
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* test warnings

* warn asserts return value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants