-
Notifications
You must be signed in to change notification settings - Fork 185
Unable to override default tree delimiter #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
bug
Something isn’t working
Comments
Fil
added a commit
that referenced
this issue
Sep 7, 2023
(note: I don't think this is the correct fix! But at least it gives a unit test) closes #1849
Thanks for the report! See #1850 for a potential fix |
Oh, yikes. Good report! Thank you. |
mbostock
pushed a commit
that referenced
this issue
Sep 12, 2023
(note: I don't think this is the correct fix! But at least it gives a unit test) closes #1849
mbostock
added a commit
that referenced
this issue
Sep 12, 2023
* ignore / if the delimiter is something else (note: I don't think this is the correct fix! But at least it gives a unit test) closes #1849 * avoid string.replaceAll * add delimiter test * \/ needs three (six) backslashes! * pass tests, but still not complete * proper escape/unescape * refactor logic * lift delimiter code * tweak error message * refactor logic slightly --------- Co-authored-by: Mike Bostock <[email protected]>
Fil
added a commit
that referenced
this issue
Sep 13, 2023
* ignore / if the delimiter is something else (note: I don't think this is the correct fix! But at least it gives a unit test) closes #1849 * avoid string.replaceAll * add delimiter test * \/ needs three (six) backslashes! * pass tests, but still not complete * proper escape/unescape * refactor logic * lift delimiter code * tweak error message * refactor logic slightly --------- Co-authored-by: Mike Bostock <[email protected]>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this issue
Jan 14, 2024
* ignore / if the delimiter is something else (note: I don't think this is the correct fix! But at least it gives a unit test) closes observablehq#1849 * avoid string.replaceAll * add delimiter test * \/ needs three (six) backslashes! * pass tests, but still not complete * proper escape/unescape * refactor logic * lift delimiter code * tweak error message * refactor logic slightly --------- Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The custom delimiter should replace the default delimiter, instead of being appended to it.
Repro: https://observablehq.com/d/96ac483a54482567
Code
Expected
In Plot.tree, declaring a custom delimiter
;
should result in a tree where only;
is used as a delimiter.Actual
In Plot.tree, declaring a custom delimiter
;
results in a tree where both;
and/
are used as delimiters.The text was updated successfully, but these errors were encountered: