Skip to content

pointerX can fail with faceting #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fil opened this issue Aug 1, 2023 · 0 comments · Fixed by #1777
Closed

pointerX can fail with faceting #1776

Fil opened this issue Aug 1, 2023 · 0 comments · Fixed by #1777
Assignees
Labels
bug Something isn’t working

Comments

@Fil
Copy link
Contributor

Fil commented Aug 1, 2023

as reported by @yurivish in https://observablehq.com/d/3264dbb558b44080, using pointerX (e.g. to browse faceted timelines) fails when the facets are aligned vertically can in some cases feel “wrong”.

minimal repro:

Plot.lineY(industries, {
  x: "date",
  y: "unemployed",
  fx: (d) => d.date.getDay(),
  fy: (d) => d.date.getFullYear(),
  stroke: "industry",
  tip: true
}).plot()
Enregistrement.de.l.ecran.2023-08-01.a.11.37.39.mov
@Fil Fil added the bug Something isn’t working label Aug 1, 2023
@Fil Fil self-assigned this Aug 1, 2023
Fil added a commit that referenced this issue Aug 1, 2023
mbostock pushed a commit that referenced this issue Aug 10, 2023
@Fil Fil closed this as completed in #1777 Aug 10, 2023
Fil added a commit that referenced this issue Aug 10, 2023
Fil added a commit that referenced this issue Aug 21, 2023
chaichontat pushed a commit to chaichontat/plot that referenced this issue Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant