Skip to content

Plot.geo with tip: true collapses the chart #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Fil opened this issue Jul 10, 2023 · 0 comments · Fixed by #1746
Closed

Plot.geo with tip: true collapses the chart #1742

Fil opened this issue Jul 10, 2023 · 0 comments · Fixed by #1746
Labels
bug Something isn’t working

Comments

@Fil
Copy link
Contributor

Fil commented Jul 10, 2023

As initially reported by @yurivish (notebook), using tip: true on a non-projected geo makes the map almost vanish; if you look more closely you can see that the map exists but the x and y scales have a range [0, 1] which breaks everything (the geo path, and the axes).
@Fil Fil added the bug Something isn’t working label Jul 10, 2023
Fil added a commit that referenced this issue Jul 10, 2023
@Fil
geo + tip: true
2a7a899 
- fix collapsing bug (#1742)
- compute a centroid if there is a geometry channel but no x and y channels (#1743)
@Fil Fil mentioned this issue Jul 10, 2023
Closed
Fil added a commit that referenced this issue Jul 10, 2023
@Fil
geo + tip: true
83424fe 
- fix collapsing bug (#1742)
- compute a centroid if there is a geometry channel but no x and y channels (#1743)
Fil added a commit that referenced this issue Jul 10, 2023
@Fil
fix collapsing bug (#1742)
804a39c
Fil added a commit that referenced this issue Jul 10, 2023
@Fil
fix collapsing bug (#1742)
85da8d3
@Fil Fil mentioned this issue Jul 10, 2023
Merged
Fil added a commit that referenced this issue Jul 10, 2023
@Fil
fix collapsing bug (#1742)
b3e1318
mbostock added a commit that referenced this issue Jul 11, 2023
@Fil @mbostock
tip on a geo mark without a projection should not collapse the chart (#…
39f1b72 
…1746)

* fix collapsing bug (#1742)

* avoid array.includes

---------

Co-authored-by: Mike Bostock <[email protected]>
Fil added a commit that referenced this issue Aug 21, 2023
@Fil @mbostock
tip on a geo mark without a projection should not collapse the chart (#…
9747e02 
…1746)

* fix collapsing bug (#1742)

* avoid array.includes

---------

Co-authored-by: Mike Bostock <[email protected]>
chaichontat pushed a commit to chaichontat/plot that referenced this issue Jan 14, 2024
@Fil @mbostock @chaichontat
tip on a geo mark without a projection should not collapse the chart (o…
3bf4a3c 
…bservablehq#1746)

* fix collapsing bug (observablehq#1742)

* avoid array.includes

---------

Co-authored-by: Mike Bostock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
1 participant
@Fil