Skip to content

adopt and document the new apache-arrow date encoding #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

Fil
Copy link
Contributor

@Fil Fil commented May 21, 2024

@Fil Fil requested a review from mbostock May 21, 2024 11:16
@Fil Fil mentioned this pull request May 21, 2024
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the Arrow page, but it doesn’t fix the DuckDB page which uses SQL cells.

Screenshot 2024-05-21 at 9 11 40 AM

And, it’s not possible to workaround it by passing additional hints to Inputs.table since you can’t configure how tables are displayed in SQL cells (currently). And also, Inputs.table should just work as-is with Apache Arrow tables; users shouldn’t have to apply a workaround for something so common. We embrace the Arrow table representation for tabular data and it makes sense for Inputs.table to be aware of it and present data accordingly. And ideally Plot, too, in the future.

@Fil Fil merged commit 118b715 into main May 21, 2024
4 checks passed
@Fil Fil deleted the fil/arrow-dates branch May 21, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants