Skip to content

Fix react conflicting peer dependency with react-reconciler #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

NinZine
Copy link
Contributor

@NinZine NinZine commented Oct 16, 2021

Reverting back to react@^16.x.x. react-reconciler should be
updated separately so that it can safely be used with [email protected].

react-reconciler should be version 0.26.2 and requires some refactoring.

When installing react-nodegui as a dependency. It will yield a
warning:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react
npm WARN   react@"^17.0.2" from the root project
npm WARN   1 more (@nodegui/react-nodegui)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.13.1" from [email protected]
npm WARN node_modules/react-reconciler
npm WARN   react-reconciler@"^0.25.1" from @nodegui/[email protected]
npm WARN   node_modules/@nodegui/react-nodegui
npm WARN
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react
npm WARN   peer react@"^16.13.1" from [email protected]
npm WARN   node_modules/react-reconciler
npm WARN     react-reconciler@"^0.25.1" from @nodegui/[email protected]
npm WARN     node_modules/@nodegui/react-nodegui

Reverting back to `react@^16.x.x`. `react-reconciler` should be
updated separately so that it can safely be used with `[email protected]`.

When installing `react-nodegui` as a dependency. It will yield a
warning:
```
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react
npm WARN   react@"^17.0.2" from the root project
npm WARN   1 more (@nodegui/react-nodegui)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.13.1" from [email protected]
npm WARN node_modules/react-reconciler
npm WARN   react-reconciler@"^0.25.1" from @nodegui/[email protected]
npm WARN   node_modules/@nodegui/react-nodegui
npm WARN
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react
npm WARN   peer react@"^16.13.1" from [email protected]
npm WARN   node_modules/react-reconciler
npm WARN     react-reconciler@"^0.25.1" from @nodegui/[email protected]
npm WARN     node_modules/@nodegui/react-nodegui
```
@Dauto98
Copy link

Dauto98 commented Jul 7, 2022

Hi, right now I still have this issue with [email protected] and [email protected]. Any progress since then?

@a7ul a7ul merged commit 730caa3 into nodegui:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants