BUG: Fix future warning on use of np.issubdtype.
#707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure whether this will fix the issue/whether it is the right thing to do, though. |
effigies
reviewed
Dec 25, 2018
Fix future warning on use of `np.issubdtype`. Fixes: ``` /home/travis/build/nipy/dipy/venv/lib/python3.4/site-packages/nibabel/streamlines/array_sequence.py:23: FutureWarning: Conversion of the second argument of issubdtype from `bool` to `np.generic` is deprecated. In future, it will be treated as `np.bool_ == np.dtype(bool).type`. ``` observed in projects using Nibabel, e.g. DIPY: https://travis-ci.org/nipy/dipy/jobs/471947136 More information about the issue and the fix at: numpy/numpy#2334 numpy/numpy#9505
jhlegarreta
force-pushed
the
FixNumpyissubdtypeMethodFutureWarningDeprecation
branch
from
fbdd035 to
fb76411
Compare
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
+ Coverage 88.85% 88.88% +0.03%
==========================================
Files 93 93
Lines 11454 11449 -5
Branches 1894 1892 -2
==========================================
- Hits 10177 10176 -1
+ Misses 936 933 -3
+ Partials 341 340 -1
Continue to review full report at Codecov.
|
jhlegarreta
deleted the
FixNumpyissubdtypeMethodFutureWarningDeprecation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix future warning on use of
np.issubdtype. Fixes:observed in projects using Nibabel, e.g. DIPY:
https://travis-ci.org/nipy/dipy/jobs/471947136
More information about the issue and the fix at:
numpy/numpy#2334
numpy/numpy#9505