ENH: Add crosshair toggling to OrthoSlicer3D

[mko010]

Add a toggle for crosshairs with ctrl+x

Closes #689.

[coveralls]

Coverage decreased (-0.02%) to 91.828% when pulling 099d975 on mko010:master into a960b92 on nipy:master.

[effigies]

Hi, sorry about the slow review. I think this is almost good to go, but on another look through, you can drop a branch.

[effigies]

No need for else: pass.

[mko010]

Thanks for the review, I will review it tomorrow, or when I have time to do it. Have a good day. El vie., 21 dic. 2018 23:36, Chris Markiewicz <[email protected]<mailto:[email protected]>> escribió: @effigies commented on this pull request. Hi, sorry about the slow review. I think this is almost good to go, but on another look through, you can drop a branch.

________________________________ In nibabel/viewers.py<#701 (comment)>:

@@ -498,8 +502,11 @@ def _draw(self):

for ii in range(3): ax = self._axes[ii] ax.draw_artist(self._ims[ii]) - for line in self._crosshairs[ii].values(): - ax.draw_artist(line) + if self._cross: + for line in self._crosshairs[ii].values(): + ax.draw_artist(line) + else: + pass No need for else: pass. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#701 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AgQ0dbyK6ermTDlw1MQ12e90P4yHKh0Uks5u7WJ1gaJpZM4ZN5md>.

[codecov-io]

Codecov Report

Merging #701 into master will decrease coverage by 0.03%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   88.88%   88.85%   -0.04%     
==========================================
  Files          93       93              
  Lines       11449    11454       +5     
  Branches     1892     1894       +2     
==========================================
+ Hits        10176    10177       +1     
- Misses        933      936       +3     
- Partials      340      341       +1

Impacted Files	Coverage Δ
nibabel/viewers.py	95.4% <42.85%> (-1.26%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a960b92...099d975. Read the comment docs.

[effigies]

Looks good. Thanks.

[mko010]

You are welcome! El mar., 25 dic. 2018 5:45, Chris Markiewicz <[email protected]<mailto:[email protected]>> escribió: Looks good. Thanks. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#701 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AgQ0dWQ8pXyS3Dmlo-rQItaGRt3DgOSKks5u8a1JgaJpZM4ZN5md>.